fix(feed): drop force-dynamic so the hourly revalidate actually applies - #71
Merged
royalpinto007 merged 1 commit intoAug 7, 2026
Conversation
force-dynamic and revalidate contradicted each other, forcing feed.xml to regenerate from Supabase on every request instead of caching hourly as intended.
|
This is in, @waterlemonnn. Really appreciate it. agentpostmortem gets better every time someone outside the repo digs in like this. If you find agentpostmortem useful, consider dropping a star. It helps more people find it. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`app/feed.xml/route.ts` declared both `dynamic = "force-dynamic"` and `revalidate = 3600`. The two contradict each other -- `force-dynamic` opts the route out of caching entirely, so `revalidate` never had any effect and the feed was rebuilt from Supabase on every request, including every feed-reader poll.
Went with the hourly-cache interpretation per the issue's own reasoning (cases need maintainer approval before they can appear, so nothing changes minute-to-minute) and dropped `force-dynamic`, keeping `revalidate = 3600`.
Didn't touch `app/sitemap.ts` (also mentioned in the issue) -- that's #58's territory and already has an open PR.
Verified: `npm run lint` and `npx tsc --noEmit` are clean. Couldn't verify against a live feed request (`npm run dev` + fetch `/feed.xml`) since this environment has no Supabase project configured. `npx prettier --check .` and `npm run build` both fail here, but confirmed via `git stash` that both failures are pre-existing on main (unrelated formatting warning on this file, and a missing `RESEND_API_KEY` at build time) -- not introduced by this change.
Closes #55